[Bug 28367] Add StreamTube interface support

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28367

--- Comment #12 from Dario Freddi <drf54321 at gmail.com> 2010-08-16 05:38:23 PDT ---
Hey, I pushed to my branch all the needed changes. While I was at it, I took
the chance to push a quick fix to my cmake branch, cherry pick please.

However, I fixed everything you pointed out except for a pair of things.
Moreover, some of the things you pointed out (such as __k__ and the
FILE_TRANSFER stuff) were not present in the latest revision - maybe I forgot
to push some time ago. Anyway.

(In reply to comment #10)
> - On documentation use the constants such as 
> TELEPATHY_INTERFACE_CHANNEL_INTERFACE_TUBE instead of using the string literal.
> - Indicate on documentation that method X requires FeatureX, see other docs for
> example. The account class documentation is very complete

While I was at it, I took the chance to improve vastly the whole documentation,
adding a paragraph about usage in both outgoing and incoming stream tubes, in a
similar fashion to account.

> - Do not use Q_PRIVATE_SLOT, just do as done in other class using "private
> Q_SLOTS"

I actually did not do this, for the reason that this would have required to
move all of the private slots into the public classes. Given that we're aiming
to a more Qtish library, I think this would have been a wasted effort, as I'd
really like to see every private slot in public classes become a Q_PRIVATE_SLOT
once the refactoring is done. If you don't agree, though, I can change this
anyway.

> - Use include QtSomething instead of QtFoo/QtSomething

I did it, but please remember that Qt itself strongly recommends to use
QtFoo/QtSomething over QtSomething at least in public headers - probably
another thing to change in the future.

Cheers!

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.