[Bug 29090] Add support to filter accounts by RequestableChannelClasses

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29090

Olli Salli <ollisal at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|andrunko at gmail.com          |ollisal at gmail.com
         Depends on|29484                       |

--- Comment #6 from Olli Salli <ollisal at gmail.com> 2010-08-16 11:22:36 PDT ---
More of a TODO list for myself, as I'm taking over this task:

AccountManager::FeatureFilterByCapabilities should make
Account::FeatureCapabilities ready also on newly added accounts, not just the
accounts initially found in introspection. As this means accounts getting added
signal must be delayed until the feature is ready, I think this should only be
finished after AccountFactory is added.

Most of the code in the filter classes doesn't really need to be template code.
Code in PropertyFilter checking the properties should be refactored to a
non-template function taking a QObject *, while code checking the RCC subset in
the caps filter should be refactored into a non-template function taking the
RCCList. This is beneficial both for compile times and the possibility to fix
bugs by an updated shared library containing the implementations (with no need
to recompile against newer tp-qt4).

There should be typedefs for the templated stuff.

The variant map version shouldn't be deprecated, but should be preserved as a
shortcut constructing the equivalent propertyFilter. Similar shortcut should be
added for a generic RCC filter. The additional filter channel class filter
functions reverting should be reverted (:D).

Tests should be more exhaustive.

Typos: textChatsAccounts should be textChatAccounts, etc.

Account caps changing should only be emitted if there's an actual difference.
Also, notify() should always be done.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.