[Bug 29614] Allow a user-specified TpAccountManager on TpBaseClient

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29614

--- Comment #2 from Olli Salli <ollisal at gmail.com> 2010-08-18 07:03:30 PDT ---
You probably want to check that the bus is the one the AccountManager object
given to TpBaseClient is on if both are specified.

Also, in likely-account: in which cases exactly can the account not be the
likely account? (The filter is empty, so MC shouldn't dispatch anything to us
apart from our request which will indeed have the same account). Somebody
guessing our service name and setting it as a preferred handler?

IF there are valid corner-cases, in which this can happen, then shouldn't we
actually pass the account's AccountManager, if any, to the TpBaseClient rather
than just the bus, to get correctly shared accounts outside the singleton AM
instance even if it's not the likely account?

OTOH if there actually aren't, why not just error the request in that case,
since it probably indicates MC dispatching an incorrect channel to us?

Otherwise, ++

Making account-manager construct-only like you did seems like the way to go for
the simple semantics, I'll probably make it a constructor param for an added
constructor to the tp-qt4 AbstractClient base-classes too.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.