[Bug 29699] New: Tp::ChannelRequest incorrectly checks immutable properties

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Aug 20 12:51:01 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=29699

           Summary: Tp::ChannelRequest incorrectly checks immutable
                    properties
           Product: Telepathy
           Version: git master
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: tp-qt4
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: will.thompson at collabora.co.uk
         QAContact: telepathy-bugs at lists.freedesktop.org


In response to a reported problem about Tp::ChannelRequest not becoming ready,
I had a poke around its implementation.

Every property on ChannelRequest is immutable, so there should be no reason for
introspectMain() to call GetAll() again.

However, extractMainProps(), called from the ctor, expects the QVariantMap's
keys to be unqualified names like "Account" rather than qualified names like
"org.freedesktop....ChannelRequest.Account", as they are documented to be by
<http://telepathy.freedesktop.org/spec/Client_Interface_Requests.html#org.freedesktop.Telepathy.Client.Interface.Requests.AddRequest>.

So yeah, this seems broken. :)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list