[Bug 28866] Allow channel requesters to associate metadata with requests for the benefit of other clients

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Aug 23 17:31:31 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=28866

--- Comment #6 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-08-23 08:31:30 PDT ---
Regarding the proof-of-concept implementation:

> +_mcd_channel_dup_properties (McdChannel *self)

I have an old branch to make channel requests into independent objects, which
Vivek said he was going to review. It'd probably be worth merging that first.

Alternatively, this function should be called
_mcd_channel_dup_request_properties, because it's the channel-request part of
the McdChannel's split personality.

> mcd-channel: store the channel request object in satisf...

I haven't reviewed this, because I think merging and using smcv/requests is
probably a better way forward.

> +        request_properties = g_hash_table_new_full (g_str_hash, g_str_equal,
> +            g_free, free_req_properties);

Couldn't the free-function just be ((GDestroyNotify) g_hash_table_unref)?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list