[Bug 29375] add something resembling GabbleBaseChannel

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29375

--- Comment #14 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-08-23 09:13:24 PDT ---
(Those review comments were relative to wjt's version of the branch, so some of
them have already been fixed.)

The echo CM has been moved to tests/lib in master because it's not actually a
good example any more (it doesn't have Messages), so I'd prefer it if you could
also port echo-message-parts, aka echo2.

Ideally, port all of them, of course (except for contact-list, which is going
to have its channels deleted when my TpBaseContactList branch lands).

If this branch lands in master before TpBaseContactList, which seems likely,
then I'll port the hidden internal channels in TpBaseContactList to use this,
and there will be much rejoicing :-)

>   * TpBaseChannel:
> + *
>   * @parent: fields shared by the superclass

That doesn't look like the right syntax to me: member docs are meant to be
immediately after the title line. What failure are you "fixing" with that?

I think what you actually want to do is to put /*<private>*/ at the beginning
of the struct (making everything private), then remove the documentation of
@parent.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.