[Bug 29614] Allow a user-specified TpAccountManager on TpBaseClient

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29614

--- Comment #6 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-08-23 10:41:21 PDT ---
(In reply to comment #4)
> better to forbid suspicious things now and relax our checks later,
> though, so I'll do that.

Done.

> I'll change the semantics from "likely account" to "only this
> account" and make HandleChannels raise InvalidArgument for other accounts.

Done.

> (In reply to comment #3)
> > Could you elaborate a bit more in TpBaseClient:account-manager: why/when a user
> > would want (or not) to pass a specific AM. I know why but I think that would be
> > less clear for people not familar with TP as that's pretty subtil.

Done.

> > Do we really need new_with_am variants for TpSimple objects? We could claim
> > that if you don't want to use the "default" AM you are not that simple any more
> > and so should use TpBaseClient directly.

I've documented these a bit better.

> > I'd add a small comment explaining why/when 
> > _tp_base_client_set_likely_account() could be used.
> 
> It's basically just for TpAccountChannelRequest; I'll say so.

Done.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.