[Bug 29751] Presence statuses extending & XMPP privacy list use by plugins

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29751

--- Comment #6 from Senko Rasic <senko at senko.net> 2010-08-25 04:11:44 PDT ---
> This patch seems to swap set_xep0126_invisible_cb and set_xep0186_invisible_cb
> — which is fine, though it would have been nicer as a separate patch. That

I've swapped them because otherwise I'd have more invasive changes to set up
privacy lists even if they're not used for invisibility, so this looked a bit
cleaner to me. Unfortunately, I did that in the middle of reorganising the
privacy list code, and couldn't decouple it into self-sufficient standalone
patches.

> said, the swap does show that the former needlessly casts user_data, while the
> latter just assigns it to a GSimpleAsyncResult *. I think they should be
> consistent, and maybe even use G_SIMPLE_ASYNC_RESULT().

For some reason I skipped this during fixing up things. Patch to consistently
use G_SIMPLE_ASYNC_RESULT pushed.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.