[Bug 29778] Port everything to TpBaseChannel and bin GabbleBaseChannel

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29778

--- Comment #6 from Will Thompson <will.thompson at collabora.co.uk> 2010-08-25 06:31:37 PDT ---
(In reply to comment #5)
> (In reply to comment #4)
> > In the search channel:
> > > +  base_class->close = tp_base_channel_destroyed;
> > 
> > Do you mean tp_base_channel_close? (Not that it necessarily matters, since this
> > channel doesn't respawn.)
> > 
> > Similarly, do you mean for gabble_server_tls_channel_close to call
> > tp_base_channel_close?
> 
> No. tp_base_channel_close() calls the ->close() vfunc. The implementation of
> ->close(), as documented, has to ultimately call one of _destroyed() or
> _respawned(). Since SearchChannel's implementation of ->close() would just call
> _destroyed() immediately, I thought I'd just implement the former *as* the
> latter.

Here is a telepathy-glib patch which improves the documentation of this stuff,
including giving this usage as an example:
http://git.collabora.co.uk/?p=user/wjt/telepathy-glib.git;a=commitdiff;h=6bb9300ee4b961c77d0cbc78a07ae89a65d39343

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.