[Bug 28199] port Gabble to TpBaseContactList

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28199

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://git.collabora.co.uk/ |http://git.collabora.co.uk/
                   |?p=user/smcv/telepathy-gabb |?p=user/smcv/telepathy-gabb
                   |le-smcv.git;a=shortlog;h=re |le-smcv.git;a=shortlog;h=re
                   |fs/heads/contact-list       |fs/heads/contact-list-fixes
           Keywords|                            |patch

--- Comment #9 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-08-26 06:54:44 PDT ---
> roster/authorize.py is new and doesn't exercise the old API; I could test the
> old API as well, I suppose.

Done.

> > http://git.collabora.co.uk/?p=user/smcv/telepathy-gabble-smcv.git;a=commitdiff;h=a132acd51f6bf7d9c1cec5c801704f5305fdcf03
> > if the change didn't stick, shouldn't conn.Contacts.GetContactAttributes()
> > return the "people starting with A" group as well?

This was in fact right: GCLA() wasn't called until after the case where it
didn't stick, *and* the case where it did. I've added another call to GCLA() to
make it more clearly correct.

> > I try to use "pyflakes" when adding new tests. For example pyflakes
> > tests/twisted/roster/edit-before-roster.py returns a bunch of trivial warnings
> > that could easily be fixed.
> > Same for tests/twisted/roster/authorize.py

Done, but I'm really not convinced that removing unused imports and variables
from regression tests is very productive...

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.