[Bug 29147] Shouldn't include <x xmlns=...muc.../> in presence updates to MUCs

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29147

--- Comment #5 from Will Thompson <will.thompson at collabora.co.uk> 2010-12-01 03:58:03 PST ---
(In reply to comment #4)
> Damnit, this breaks some tubes tests.

I fixed those tests. They were erroneously asserting that the element was
present.

I discussed the rationale for M-Link's behaviour with the M-Link developers,
and they convinced me that their behaviour is sensible. There are basically two
cases you might want to recover from:

1. The server thinks you're in the MUC, but the client doesn't.

Apparently this actually does happen in practice. Without M-Link's behaviour,
when the client tries to join the MUC the server misconstrues it as a presence
update, so it echoes it back to you. Now your client thinks it's in the MUC,
but the full user list hasn't been pushed to it, nor the topic, etc. etc.

With M-Link's behaviour, when you try to join the server thinks “oh, maybe they
weren't in the room after all” and treats your join as a join.

2. The server thinks you're not in the MUC, but the client thinks it is.

With Gabble's current behaviour, sending a presence update to a MUC looks like
a join. But with the change in behaviour, the bare presence update also looks
like a join, albeit a groupchat 1.0 (pre-XMPP) join. So this works too.

So all in all I think this change is good.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.