[Bug 23155] Connection: make handles survive until disconnection

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Dec 1 16:36:49 CET 2010


https://bugs.freedesktop.org/show_bug.cgi?id=23155

--- Comment #14 from Will Thompson <will.thompson at collabora.co.uk> 2010-12-01 07:36:48 PST ---
Spec:

+        <p>If Connection.HasImmortalHandles is true, which SHOULD always
+          be the case, this method does nothing and returns successfully.</p>

Linkify the property name, plz. Ditto other places. Also, please be consistent
as to whether you call it "Connection.HII" or just "HII".

Otherwise fine.

tp-glib:

Functions like tp_handle_Ref() which are now documented thusly:

+ * Do nothing. This previously provided refcounting for handles, but handles
+ * now last as long as the connection.

should note which version this changed in.

Otherwise the tp-glib branch looks fine. I like branches that delete code.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list