[Bug 23155] Connection: make handles survive until disconnection

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Dec 1 18:25:03 CET 2010


https://bugs.freedesktop.org/show_bug.cgi?id=23155

--- Comment #17 from Will Thompson <will.thompson at collabora.co.uk> 2010-12-01 09:25:02 PST ---
(In reply to comment #15)
> telepathy-glib branch smcv/leak-handles updated.
> 
> I've also added a branch at
> http://git.collabora.co.uk/?p=user/smcv/telepathy-glib-smcv.git;a=shortlog;h=refs/heads/immortality
> which discards most of the handle refcounting machinery on the client side (by
> the simple expedient of never releasing handles).

I'd say ship it all. I have to say I haven't reviewed the deletion of the
client-side particularly closely, but the key parts (calls to the CM) looked
okay.

(In reply to comment #16)
> (In reply to comment #14)
> > Linkify the property name, plz. Ditto other places. Also, please be consistent
> > as to whether you call it "Connection.HII" or just "HII".
> 
> Done (consistently using the bare name), + wording improvements.

Also looks fine.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list