[Bug 24901] voicemail interface usable with at least GSM and Skype

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=24901

--- Comment #24 from Danielle Madeley <danielle.madeley at collabora.co.uk> 2010-12-01 19:50:39 PST ---
(In reply to comment #23)

> If you're going to do that...
> ... then these properties don't necessarily need to be properties (since
> they're no longer part of the request), they can be an a{sv} of extra
> information.
> 
> I assume that informational stuff like the sender is pretty irrelevant for the
> observer/handler of the voicemail channel: if that's the case, then the
> sender/timestamp/bees don't need to be properties on the channel at all.

I think it is still useful. We may want to log that you downloaded voicemail,
but more importantly, the handler may want to show metadata about the voicemail
(Sender, Duration, Time) and it doesn't seem reasonable to have to go back to
the connection in order to look that information up. We could collapse it down
into a single VoicemailMetadata property. I'm not entirely sure what that gains
us though.

> > I'm thinking in these instances, we should simply omit the VoicemailToken,
> > meaning a request cannot be made.
> 
> If voicemails are a (token, info) tuple, you can't omit the token. Omitting the
> token would break your API for DeleteVoicemail and VoicemailsRemoved, though,
> so I don't think that's a good idea anyway.
> 
> Having non-unique tokens would also break DeleteVoicemail and VoicemailsRemoved
> - if you've told me { token: "generic-voicemail-box", sender-id: "smcv" } and {
> token: "generic-voicemail-box", sender-id: "sjoerd" }, how do you indicate that
> the voicemail from me has been removed but the one from Sjoerd is still there?

Very good point. Rather than a requestable channel class (plus badgers), we
could return to using 'aa{sv}'s for Delete and Removed.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.