[Bug 32053] Add a TpContactSearch proxy object

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=32053

--- Comment #2 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2010-12-03 01:01:29 PST ---
You didn't add new API to telepathy-glib-sections.txt. Please build with
--enable-gtk-doc and make sure than "make check" pass.

Speaking of checking, it would be good to have tests.

I didn't look at the details of the code, just the API:

- Maybe the API should be TpAccount centric rather than TpConnection ? Don't
know

- tp_contact_search_set_connection() seems wrong, I'd make the conn/account
prop construct only.
That would also use to get rid of the search-keys-changed signal.

- Rename tp_contact_search_search() to tp_contact_search_start()?

- We need API to know the supported search terms.

- You don't use the More() method if needed.

- It would be good to return an higher level structur for results. Maybe we
could use TpContact ?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.