[Bug 32053] Add a TpContactSearch proxy object

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Dec 7 01:10:27 CET 2010


https://bugs.freedesktop.org/show_bug.cgi?id=32053

--- Comment #7 from Danielle Madeley <danielle.madeley at collabora.co.uk> 2010-12-06 16:10:26 PST ---
(In reply to comment #5)
> What do you think of:
> 
> typedef gboolean (TpContactSearchCallback *) (TpContactSearch *self,
>     const GError *error,
>     GList *results,
>     gpointer user_data);
> 
> void tp_contact_search_start (TpContactSearch *self,
>     const GHashTable *keys,
>     TpContactSearchCallback cb,
>     gpointer user_data);

I think you should use a regular GSignal, rather than a callback. That allows
more than one person to connect to the results if they're so interested.

I also think you want results to appear in the list as they are returned by the
server. Not all servers return the search results immediately, but trickle them
out as they're found.

I think we should simply keep calling More() automatically until the user calls
Stop() or the object is disposed.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list