[Bug 24935] Emit StreamError(..., Codec_Negotiation_Failed, ..) in more cases

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=24935

Vivek Dasmohapatra <vivek at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |review-

--- Comment #4 from Vivek Dasmohapatra <vivek at collabora.co.uk> 2010-12-07 09:30:16 PST ---
trivia (don't have to be fixed for a merge):

http://git.collabora.co.uk/?p=user/eitan/telepathy-gabble.git;a=commitdiff;h=ace3ba397ca79e4b78a2cf211fd89079f2142a3a

misc indentation change in first chunk

--

http://git.collabora.co.uk/?p=user/eitan/telepathy-gabble.git;a=commitdiff;h=ce3d6bec79e2db2f8e225e5af3881e74cc33a405

can use g_str_equal rather then !tp_strdiff since txt is guaranteed not-NULL

----

trivia:

switch (…) {

not sure these switch()es are in house style, but check up on that,
I think the { should be on the next line

----

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.