[Bug 27175] Make TpMessage usable in clients

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27175

--- Comment #17 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-12-08 08:45:26 PST ---
(In reply to comment #16)
> I think I'd like some return_if_fails in _tp_signalled_message_new:
> 
> - if message-sender is nonzero, then the TpContact is non-NULL and has
>   that handle
> - if message-sender-id is nonempty, then the TpContact is non-NULL and has
>   that identifier

Also, if message-sender is absent or 0, the message-sender-id must be absent or
empty, and the TpContact must be NULL.

(TpTextChannel should take care of issuing warnings / deleting inconsistent
information before making the TpSignalledMessage, if the CM gives us a message
where message-sender and message-sender-id aren't consistent with each other.
tp_connection_dup_contact_for_immortal_handle already raises a GError if it
detects inconsistency.)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.