[Bug 32222] Potential cyclic references when using request and handle

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=32222

--- Comment #2 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-12-08 08:59:18 PST ---
16:22 < wjt> Zdra: is there *actually* a weak ref, or is it a borrowed ref?
16:22 < wjt> Zdra: (the commit message and/or comment should say, in any case)
16:23 < Zdra> wjt, it is a weakref by using "invalidated" signal
16:23 < Zdra> wjt, in that cb it remove the channel from the hashtable
16:24 < wjt> as someone who doesn't think proxies should emit invalidated in 
             'dispose'
16:24 < wjt> i do not enjoy that explanation :p

...

16:29 < smcv> I don't think being a neglectful handler is a supported action, 
              tbh
16:29 < smcv> (where by "neglectful" I mean having a channel and not closing it 
              when you're finished with it)
16:30 < smcv> I'd prefer some documentation to that effect
16:30 < smcv> (applies only to Handler, not to observer/approver)

...
16:33 < smcv> I think my preferred resolution would be to document that yes, if 
              you are a Handler, you are expected to close any channel you're 
              no longer using
16:34 < smcv> shaky rationale: you know best when you've stopped using it
16:36 < Zdra> well, tell handlers to call Close() but still try to make it just 
              work if you just drop your last ref, is nicer IMO
16:37 < smcv> I suppose you could have it g_warning() and Close() if the last 
              ref is dropped without closing it...

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.