[Bug 32222] Potential cyclic references when using request and handle

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=32222

--- Comment #4 from Xavier Claessens <xclaesse at gmail.com> 2010-12-09 00:58:37 PST ---
There is no high-level API to close a channel and TpSimpleHandler's doc never
say we have to close a channel... So with current API it seemed obvious that
unreffing the TpChannel is enough to be done with it.

Note that when using 
tp_account_channel_request_create_and_handle_channel_async(), there is actually
no need to close the channel since unreffing it will cause the handler to die
and MC close the channel for us. I think that API is made to make the simple
case easy and it would be cool to not have to explicitly Close() the channel.

So I disagree with adding a g_warning() since I see now reason an explicit
Close() is required, and not emitting "invalidated" on dispose would be API
break IMO. Though the API doc could recommand to close a channel.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.