[Bug 30617] TpChannel: high level API to close/leave channel

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Dec 9 12:38:09 CET 2010


https://bugs.freedesktop.org/show_bug.cgi?id=30617

--- Comment #8 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-12-09 03:38:08 PST ---
I'm starting to think the assumption made by
mcp_dispatch_operation_leave_channels (that RemoveMembers([self], No_Reason) is
exactly equivalent to Close()) might not be such a good idea. Sorry about
that...

Perhaps it'd be better to have close_async() always be Close(),
leave_group_async() always be removal of the self-handle, and leave it at
that...

Arguments in favour of having the C methods directly mirror the D-Bus calls:

* close_async() always does the right thing for Call

* leave_group_async() is easier to document, since it always fails on a
non-Group

* if we add proxy mode to Idle (Bug #24273) we need to distinguish between the
two actions anyway

Arguments in favour of what MC does:

* some old CM versions can't RemoveMembers([self]) unless the flags allow
kicking the other user (this made sense when I implemented it in MC, but now
the answer is probably to fix the CM)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list