[Bug 27175] Make TpMessage usable in clients

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27175

--- Comment #19 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-12-09 06:32:34 PST ---
+ * @deprecated since 0.13.UNRELEASED. Handles are now immortables so there is
...
+ /* Handles are now immortables so we don't have to anything */

typo: immortal

+ * no point to ref them. Furthermore, the only handles that should be stored

grammar: the only handle that should (because you refer to it as singular
afterwards)

(In reply to comment #18)
> > I'd rather not officially deprecate tp_message_new(), tp_message_ref_handle(),
> > tp_message_set_handle(), tp_message_take_message() until the replacements have
> > been in a release and a decent number of CMs (at least the usual suspects -
> > Gabble, Haze, Salut, Idle, tpsip) have been ported.
> 
> Why? Aren't deprecate optionnal? We can still use them if needed.

Most of our CMs normally compile with -Wdeprecated-declarations -Werror, so
insta-deprecating things seems a little unfriendly to CM developers :-)

Since the migration path is so trivial in this case, perhaps it's not a
problem.

> > Either the first thing cm-message-internal.h does should be to #include
> > <telepathy-glib/cm-message.h>, or the first thing the .c does should be to
> > #include the *public* .h to verify its self-containedness; preferably both. The
> > same applies to message-internal.h, message.h, message.c (but signalled-message
> > looks OK).
> 
> I tried to do that but hit weird compilation error as said on IRC. I didn't
> manage to reproduce them in a simple case.

That's a bit worrying, because it means one of our headers isn't properly
self-contained. If you compile this:

    #include <telepathy-glib/cm-message.h>
    int main (void) { return 0; }

does it work? Likewise for message.h?

Other than that, this looks good.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.