[Bug 29531] high-level API for text channels

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29531

--- Comment #19 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2010-12-10 07:00:08 PST ---
(In reply to comment #18)
> (In reply to comment #17)
> > > There is one pathological case where we might get messages with a nonzero
> > > handle but be forced to omit the sender contact:
> > > 
> > > * the CM is old, and so doesn't have immortal handles
> > > * the CM is old, and so doesn't specify message-sender-id
> > > * the handle was valid when we received the message, but became invalid before
> > > we could do HoldHandles on it
> > 
> > Humm, how can I detect such case? Should I always treat it as it when I get a
> > Message without message-sender-id on a connection not having immortal handles?
> 
> You get a message with a nonzero message-sender but no message-sender-id, you
> call get_contacts_by_handle, and either you get an error or the handle comes
> back in the "failed" set.

Ok, I think my code does the best it can to avoid such case.

> > We could add the preparation of CONNECTED in the CORE preparation of the
> > channel.
> 
> We can't do that for TpChannel in general, because TLS and SASL channels need
> to be dispatched before the connection can connect.
> 
> We could perhaps do that for TpTextChannel's core feature if you wanted,
> though.

Yeah that's what I meant. Or maybe we shouldn't bother as that's just a
fallback and just not send any sender if message-sender(-id) is not set AND
tp_connection_get_self_contact() returns NULL?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.