[Bug 32353] improve <annotation> support

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=32353

--- Comment #3 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-12-15 06:31:32 PST ---
(In reply to comment #2)
> The logic is: presence of a tp:deprecated element (ie: self.deprecated is not
> None) sets self.is_deprecated to true unconditionally.  If that element doesn't
> exist (self.deprecated is None), self.is_deprecated is set based on the
> existance and value of the annotation (if the annotation is absent, the ==
> 'true' obviously results in False).

Hmm, I see how it works now. I think it'd be clearer if you moved
"self.is_deprecated = True" to be an "else" clause (i.e. self.deprecated is not
None), rather than setting it to True and then immediately changing it to False
in the (common!) non-deprecated case.

(In reply to comment #2)
> > > +    EMITS_CHANGED_UNKNOWN     = 0
> > > +    EMITS_CHANGED_NONE        = 1
> > > +    EMITS_CHANGED_UPDATES     = 2
> > > +    EMITS_CHANGED_INVALIDATES = 3
> > 
> > Nitpicking: PEP 8 recommends not aligning like that, but just having "x = y"
> > with one space on each side.
> 
> Following existing style :-)

Fair enough... you're welcome to PEP8ify either/both, or leave both as-is.

Other than that, this looks good.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.