[Bug 32414] New: Dramatically simplify getting the dict of account parameters

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=32414

           Summary: Dramatically simplify getting the dict of account
                    parameters
           Product: Telepathy
           Version: git master
          Platform: Other
               URL: http://git.collabora.co.uk/?p=user/wjt/telepathy-missi
                    on-control-wjt.git;a=shortlog;h=refs/heads/simplify-ge
                    tting-parameters
        OS/Version: All
            Status: NEW
          Keywords: patch
          Severity: normal
          Priority: medium
         Component: mission-control
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: will.thompson at collabora.co.uk
         QAContact: telepathy-bugs at lists.freedesktop.org


_mcd_account_dup_parameters() is asynchronous for no good reason. These days,
getting each parameter from the relevant storage backend is synchronous, so
there's this whole pile of complexity which doesn't add anything. Here's a
branch that removes it. It makes things much easier to read, and removes a
tonne of code.

 src/Makefile.am                                |    1 -
 src/mcd-account-connection.c                   |   31 +-
 src/mcd-account-manager.c                      |   14 +-
 src/mcd-account-manager.h                      |    3 -
 src/mcd-account-priv.h                         |    5 +-
 src/mcd-account.c                              |  714 ++++++++----------------
 src/mcd-account.h                              |   23 +-
 src/mcd-dbusprop.c                             |   67 +--
 src/mcd-dbusprop.h                             |    1 -
 src/mcd-dispatch-operation.c                   |    9 +-
 src/mcd-dispatcher.c                           |    6 +-
 src/mcd-dispatcher.h                           |    5 -
 src/mcd-presence-frame.h                       |   13 -
 src/plugin-account.c                           |    8 +-
 test/twisted/account-manager/account-basics.py |    2 +-
 15 files changed, 295 insertions(+), 607 deletions(-)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.