[Bug 29531] high-level API for text channels

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29531

--- Comment #27 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-12-16 04:07:55 PST ---
Re-review part 2: the test.

>   test->wait = 2;
>   g_main_loop_run (test->mainloop);

No need to change it now, but I'm starting to prefer this idiom:

    while (thing_hasnt_happened (test) || other_thing_we_need < 6)
      g_main_context_iteration (NULL, TRUE);

which removes a lot of the strange action-at-a-distance you get from starting
and stopping the main loop.

>  /* TODO: check sender */

What did you want to check?

>  /* We have to prepare the pending messages feature to be notified about
>   * incoming messages */
>  /* FIXME: Shouldn't we rename this feature then ? */

Yeah, it might be better as TP_TEXT_CHANNEL_FEATURE_MESSAGES or
TP_TEXT_CHANNEL_FEATURE_INCOMING_MESSAGES.

The test looks fine.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.