[Bug 32053] Add a TpContactSearch proxy object

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=32053

--- Comment #23 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-12-16 10:30:39 PST ---
(In reply to comment #22)
> (In reply to comment #20)
> > > +tp_capabilities_supports_contact_search (TpCapabilities *self,
> > 
> > If there are fixed properties other than the channel type, your channel request
> > is going to fail, because you only provide the channel type. So, you should
> > skip channel classes that have more than one fixed property, for
> > forwards-compat.
> 
> Hmm, can you clarify this a bit?

Sure. A Gabble contact search requestable-channel-class currently looks like
this (with suitable abbreviations):

    Fixed = { ChannelType: ContactSearch }, Allowed = [Server, Limit]

and you make one of these requests:

    { ChannelType: ContactSearch, Server: "directory.example.com" }
    { ChannelType: ContactSearch, Limit: 42 }
    { ChannelType: ContactSearch, Server: "directory.example.com", Limit: 42 }

All good so far. Similarly, if Server and/or Limit isn't allowed, you cope.

However, imagine a CM requires you to put more in your request, so its RCC
looks like this:

    Fixed = { ChannelType: ContactSearch,
        Hypothetical.SearchType: "randomly" }, Allowed = [Limit]

Your TpCapabilities code would say "yes, I can work with that", but then when
you came to do the request, you wouldn't match the Hypothetical.SearchType that
the CM demanded, and your channel request would fail.

> > (I note in passing that the channel type in telepathy-spec should specify a
> > typical requestable channel class, and the channel class used in Gabble
> > violates "SHOULD always include [...] TargetHandleType". Oh well. We'll just
> > have to document that in the spec...)
> 
> Just to be sure, there's nothing for me to fix in TpCS, right?

Not for that paragraph.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.