[Bug 32477] Log Call events

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=32477

--- Comment #3 from Emilio Pozuelo Monfort <pochu27 at gmail.com> 2010-12-24 11:26:05 PST ---
(In reply to comment #2)
> As the type is construct-only (which totally makes sense), it would be good to
> not expose _tpl_entry_set_type() and force to pass it during object creation.
> I know that most of this code is not doing that, but best to try to get away
> from this bad pattern. :)

Makes sense.

> Ideally, couldn't we get rid of TplEntryType, make TplEntry abstract and use
> inheritance to get the type?

But this is even better. TplEntry was already an abstract type. I've now got
rid of TplEntryType and I'm using TPL_IS_ENTRY_FOO to distinguish between
different types. Is that what you mean with using inheritance to get the type?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.