[Bug 27270] TplLogManager: clean up API

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27270

Emilio Pozuelo Monfort <pochu27 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pochu27 at gmail.com

--- Comment #14 from Emilio Pozuelo Monfort <pochu27 at gmail.com> 2010-12-26 17:38:28 PST ---
(In reply to comment #5)
> I think a conversation should be identified by:
> 
> * an opaque string (or opaque object path?) that is globally unique, or
> * a tuple (type_enum, string) that is globally unique, or
> * some other defined tuple of things (perhaps it needs to include the backend
> ID?)
> 
> Of those options, I prefer the first for its simplicity, but if there are
> design constraints that mean we can't do that, we should have a real definition
> of one of the others.
> 
> Would a call be a chat ID, or be part of a thing-with-a-chat-ID, or what? How
> about a file transfer?

We need to abstract this somehow and stop exposing "gboolean chatroom" all over
the public API. See bug #32477. They seem to be exposed so tp-logger knows
whether to add "chatrooms/" to the URI to look for the logs.

We should remove that from the API, maybe adding a generic way to specify the
event type if we really need that, e.g. with a TplLogType type arg, with
TplLogType being an enum with TPL_LOG_TYPE_CHATROOM, _CALL, _FILE_TRANSFER, etc
values.

Opinions? I can probably get to this soon.

Also what should I do when breaking API? Add new one and deprecate the old, or
are we planning on breaking it for the next major release and I can just do
that then? I guess the former...

> I suspect that the real situation is more like this:
> 
> * "chat ID" is secretly less opaque than it looks, and that it really means
> "the string form of a handle", and is secretly namespaced by a TpHandleType,
> except that MSN-style nameless chats have some sort of UUID (?) instead
> * clients have to know how the chat IDs work in order to do a suitable query
> 
> Is that what's happening here? If so, we should just say it; referring to
> telepathy-spec as a canonical document is better than leaving it vague.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.