[Bug 26014] gateway registration plugin doesn't actually exchange subscriptions

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=26014


Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED




--- Comment #4 from Simon McVittie <simon.mcvittie at collabora.co.uk>  2010-02-22 11:00:44 PST ---
(In reply to comment #3)
> When you're normalizing, why not do:
> 
> if (!wocky_decode_jid (gateway, &node, &domain, &resource))
>   blow up;
> 
> if (node != NULL || resource != NULL)
>   blow up;
> 
> rather than manually looking for @ and / yourself? Maybe this would actually
> make the code longer.

I think it would, due to having to free node and resource on the error path.

> I could possibly be convinced that wocky_decode_jid() should blow up itself if
> the node param is NULL but the jid has a node...

We discussed the possibility of having a special value
WOCKY_JID_COMPONENT_FORBIDDEN (or something), which would be #defined to
(((char *) NULL) + 1) or some such, and would have these semantics.

For now I'm just going to merge this.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.