[Bug 26712] Telepathy-logger should support storing and retrieving favorite Telepathy contacts

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=26712





--- Comment #3 from Travis Reitter <travis.reitter at collabora.co.uk>  2010-02-24 19:22:02 PST ---
(In reply to comment #2)
> (In reply to comment #1)
> I've addressed all of these concerns in the two new commits to favorites-try2,
> except for changing the signals to FavouriteContactsChanged (which I just
> realized).
> 
> Danielle, could you please re-review this?
> 
> It's probably easiest to view all three changes together, since there's a lot
> of noise between the first and third commits (the second commit just extends
> the TplActionChain API).
> 

And, for what it's worth, I did a bit of careful manual testing of this new
code - of course it'd be better with some real, automated tests, but I'm a bit
cramped on time right now.

Most of the race-condition-solving method handler queuing that made this last
couple of commits so complicated won't happen in real life very often at all,
but it seems pretty solid now.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.