[Bug 28334] Test library missing namespace (making it much more difficult to bind in other languages)

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28334

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
  Status Whiteboard|                            |review-
           Keywords|                            |patch
         AssignedTo|telepathy-bugs at lists.freede |travis.reitter at collabora.co
                   |sktop.org                   |.uk

--- Comment #1 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-06-01 03:08:02 PDT ---
The test library isn't really a proper library, but if Vala really can't deal
with code that isn't at least pretending to be a library, and you need the test
pseudo-library for the Vala tests, I suppose we could re-namespace it.

However, this is far too large for a single patch and I'd much prefer it in
sensible-sized patches: for instance, one to rename each GObject class and make
the tests pass again, and one for each utility function or group of utility
functions.

> tp_tests_clear_object

Unless I'm missing something, this macro is useless for bindings, so renaming
it is meaningless?

(I'm tempted to add it to the public util.h as tp_clear_object, though; we do
this sort of boilerplate often enough that it seems potentially useful. CPython
has Py_CLEAR for this purpose.)

> tp_tests_assert_no_error

If you're going to replace this with anything, please replace calls to it with
g_assert_no_error() and delete the definition. I didn't do this systematically
yet because it would be a relatively intrusive patch (although, less intrusive
than this one).

> test_connection_run_until_dbus_queue_processed

If you're going to replace this with anything, please replace it with
test_proxy_run_until_dbus_queue_processed and delete the definition. I didn't
do this systematically yet because it would be a relatively intrusive patch.

> test_connection_run_until_ready

If you're going to replace this with anything, please replace it with
test_proxy_run_until_prepared (., [TP_CONNECTION_FEATURE_CONNECTED]) and delete
the definition. I didn't do this systematically yet because it would be a
relatively intrusive patch.

> test_connection_manager_run_until_ready

Likewise, but test_proxy_run_until_prepared (., NULL).

> test_connection_manager_run_until_readying_fails

Likewise, but tp_tests_proxy_run_until_prepared_or_failed (cm, NULL, &error)
and ensure it's followed by either g_assert_error (error, domain, code) or
g_assert (error != NULL).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.