[Bug 28334] Test library missing namespace (making it much more difficult to bind in other languages)

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28334

--- Comment #2 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-06-01 06:43:21 PDT ---
(In reply to comment #1)
> > tp_tests_clear_object
> 
> Unless I'm missing something, this macro is useless for bindings, so renaming
> it is meaningless?
> 
> (I'm tempted to add it to the public util.h as tp_clear_object, though; we do
> this sort of boilerplate often enough that it seems potentially useful. CPython
> has Py_CLEAR for this purpose.)

Fixed in Bug #28345.

> > tp_tests_assert_no_error
> 
> If you're going to replace this with anything, please replace calls to it with
> g_assert_no_error() and delete the definition. I didn't do this systematically
> yet because it would be a relatively intrusive patch (although, less intrusive
> than this one).

This and the other similar things are fixed in Bug #28347.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.