[Bug 27676] ContactInfo high-level API

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27676

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|review-                     |review+ with trivial change

--- Comment #25 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-06-03 05:34:40 PDT ---
> -  g_object_unref (cancellable);
>  
> -  g_idle_add (contact_info_request_cancel, cancellable);
> +  g_idle_add_full (G_PRIORITY_HIGH, contact_info_request_cancel,
> +      cancellable, NULL);
>  
>    g_main_loop_run (result.loop);
>    g_assert_no_error (result.error);
>  
>    reset_result (&result);
>    tp_handle_unref (service_repo, handle);
> +  g_object_unref (cancellable);

Strictly speaking, the g_idle_add_full and the g_object_unref should be
combined like so:

  g_idle_add_full (G_PRIORITY_HIGH, contact_info_request_cancel,
      cancellable, g_object_unref);

to guarantee that the cancellable lives long enough for the idle to go off. r+
with that change.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.