[Bug 28200] TpBaseContactList

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28200

--- Comment #13 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-06-04 08:15:41 PDT ---
(In reply to comment #12)
> I've rewound smcv/contact-list-new-methods a bit, so it only includes the bits
> that I think will rebase cleanly onto the changes I'm making to
> contact-list-manager to implement the errata in Comment #9.

Thinking about it, I'll need to modify the new-methods branch significantly, so
it's not useful to review yet.

(In reply to comment #9)
> AuthorizePublication (au: Contacts) → nothing
> 
> For contacts with publish=No, [...] it merely records the fact that presence
> publication to those contacts is allowed; if any of those contacts ask to
> receive the local user's presence later [...] the connection SHOULD immediately
> allow them to do so, changing their publish attribute directly from No to Yes.

I've implemented this in smcv/contact-list-manager. Thinking about it, I don't
think the contact's state should visibly change when pre-approving like this,
so I didn't implement that bit.

> The various accessor methods are inconsistent about whether virtual methods can
> raise an error. I think they should all never fail, tbh.

Fixed in smcv/contact-list-manager.

> It might be good to move various "compliance levels" of groups of virtual
> methods onto GInterfaces:

Fixed in smcv/contact-list-manager.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.