[Bug 27178] keep non-public methods out of the ABI by prepending underscores

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27178

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
  Status Whiteboard|                            |review+
           Keywords|                            |patch
         AssignedTo|telepathy-bugs at lists.freede |guillaume.desmottes at collabo
                   |sktop.org                   |ra.co.uk

--- Comment #16 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-06-07 03:02:18 PDT ---
(In reply to comment #15)
> http://git.collabora.co.uk/?p=user/cassidy/telepathy-logger;a=shortlog;h=refs/heads/abi-27178

I think we can close this bug when you've merged that branch. Thanks!

> This is the remaning ABI with this branch:

Re-ordered by "group":

> Should we keep the generated API? I guess the client side one makes sense
> (Empathy currently generate it but could use this one instead) but probably not
> the server side API.
>
> tpl_iface_quark_logger
> tpl_cli_init
> tpl_cli_logger_call_add_favourite_contact
> tpl_cli_logger_call_get_favourite_contacts
> tpl_cli_logger_call_get_recent_messages
> tpl_cli_logger_call_remove_favourite_contact
> tpl_cli_logger_connect_to_favourite_contacts_changed
> tpl_svc_logger_emit_favourite_contacts_changed
> tpl_svc_logger_get_type
> tpl_svc_logger_implement_add_favourite_contact
> tpl_svc_logger_implement_get_favourite_contacts
> tpl_svc_logger_implement_get_recent_messages
> tpl_svc_logger_implement_remove_favourite_contact
> tpl_type_dbus_array_ssx
> tpl_type_dbus_struct_ssx

If the D-Bus API changes in ways that would break the service API, they'd break
the client API too, so I think it's OK to keep all of these; just be careful
about D-Bus API breaks (add + deprecate until the next library SONAME bump,
rather than removing) after we've announced the library to have ABI guarantees.

> tpl_contact_get_alias
> tpl_contact_get_avatar_token
> tpl_contact_get_contact_type
> tpl_contact_get_identifier
> tpl_contact_get_type
> tpl_log_entry_get_receiver
> tpl_log_entry_get_sender

Under discussion on Bug #27269.

> tpl_log_entry_get_account_path
> tpl_log_entry_get_pending_msg_id
> tpl_log_entry_get_timestamp
> tpl_log_entry_get_type
> tpl_log_entry_text_get_message
> tpl_log_entry_text_get_type

Under discussion on Bug #27271.

> tpl_log_manager_dup_singleton
> tpl_log_manager_exists
> tpl_log_manager_get_chats_async
> tpl_log_manager_get_chats_finish
> tpl_log_manager_get_dates_async
> tpl_log_manager_get_dates_finish
> tpl_log_manager_get_filtered_messages_async
> tpl_log_manager_get_filtered_messages_finish
> tpl_log_manager_get_messages_for_date_async
> tpl_log_manager_get_messages_for_date_finish
> tpl_log_manager_get_type
> tpl_log_manager_search_async
> tpl_log_manager_search_finish
> tpl_log_manager_search_free

Under discussion on Bug #27270.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.