[Bug 28334] Test library missing namespace (making it much more difficult to bind in other languages)

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28334

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://git.collabora.co.uk/ |http://git.collabora.co.uk/
                   |?p=user/treitter/telepathy- |?p=user/smcv/telepathy-glib
                   |glib.git;a=shortlog;h=refs/ |-smcv.git;a=shortlog;h=refs
                   |heads/test-namespacing-epic |/heads/tp-tests
                   |-refactor                   |
         AssignedTo|travis.reitter at collabora.co |simon.mcvittie at collabora.co
                   |.uk                         |.uk

--- Comment #5 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-06-07 03:07:56 PDT ---
(In reply to comment #4)
> Thanks, this looks much better. review+ with a couple of changes:
> 
> > -   * regression test that's going to be run under a temporary session bus,
> > +   * regression tp_tests that's going to be run under a temporary session bus,
> 
> Over-zealous sed detected :-)

Because I suspect this branch will cause conflicts/test failures in most other
pending telepathy-glib branches, I'd like to fast-track it in, so I've
corrected this in branch smcv/tp-tests and am stealing this bug.

> > -#endif
> > +#endif /* #ifndef __TP_TESTS_LIB_UTIL_H__ */
> > -#endif
> > +#endif /* ifndef __TP_TESTS_CONTACTS_CONN_H__ */
> 
> If anything, I'd be inclined to *remove* this comment from the multi-inclusion
> header guards.

Not a merge blocker, just a comment for the future really, so I'm ignoring
this.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.