[Bug 28241] Need tp_channel_dispatch_operation_handle_with_time_{async,finish} API

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Jun 8 12:51:38 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=28241

--- Comment #2 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-06-08 03:51:38 PDT ---
> + * Since: 0.11.5

Untrue.

> + * @user_action_timestamp: the time at which user action occurred

The long description should document what this means in terms of Gtk, something
like this:

If an X server timestamp for the user action causing this method call is
available, @user_action_timestamp should be this timestamp (for instance, the
result of gdk_event_get_time() if it is not %GDK_CURRENT_TIME). Otherwise, it
may be 0 to behave as if there was no user action or it happened a long time
ago, or %G_MAXINT64 to have the Handler behave as though the user action had
just happened (resembling, but not numerically equal to, %GDK_CURRENT_TIME).

It might even be worth adding a utility function:

gint64
tp_user_action_timestamp_from_gdk (guint32 gdk_event_time)
{
  if (gdk_event_time == 0)    /* == GDK_CURRENT_TIME */
    return G_MAXINT64;
  else
    return gdk_event_time;
}

but if we put that function in telepathy-gtk instead (when it exists), we
wouldn't have to hard-code the value of GDK_CURRENT_TIME.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list