[Bug 28230] Should query bare JID to check if PEP is supported

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28230

--- Comment #4 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-06-08 04:27:40 PDT ---
> +  /* FIXME: add OLPC iface if PEP is supported? */

Please do :-)

> +              DEBUG ("Server advertise PEP support in our jid features");

"Server advertises PEP ..."

> +/**
> + * connection_disco_cb
> + *
> + * Stage 3 of connecting
...
> + */
>  static void
>  set_status_to_connected (GabbleConnection *conn)

Wrong function name in the doc-comment

> +class PEPinJidDiscoXmppStream(BaseXmlStream):

Please be consistent about whether you capitalize acronyms in camel-case or
not, at least within a class's name (PEPInJIDDiscoXMPPStream vs.
PepInJidDiscoXmppStream).

I'd be inclined to change the behaviour of BaseXmlStream to be correct (like
PEPinJidDiscoXmppStream is now), and make the special stream class in
pep-support.py behave like the old BaseXmlStream - call it
PepInServerDiscoXmlStream, or OldEjabberdXmlStream, or something. I think it's
better if most of our tests are realistic, and legacy behaviour is the special
case.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.