[Bug 28200] TpBaseContactList

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28200

--- Comment #20 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2010-06-09 02:07:51 PDT ---
(In reply to comment #18)
> I made some changes to the new-methods stuff you already looked at while
> rebasing:
> 
> b650f02441d3fdfaf0c67408a768ce2be6be21d5 needed some minor changes as described
> in the commit message.
> 
> 82f04c4909821298ecbea278d239f6ccdf10904c is new.
> 
> 7804cabfea7b4dbb477e3a95df47f0d577f9dab2 is new.
> 
> 570465310a06171e986a92bd6bd49e9d8bf9389f needed changes: I amended the last
> paragraph.
> 
> 8d5d7baa7603f0b31456c94d566bf86a8d32b26c needed minor merging at the beginning
> of setup() (tp_tests_dbus_daemon_dup_or_die has a new name since I merged from
> master), and a different expectation at the end of
> test_add_to_publish_pre_approve (which makes more changes to the ninja's state
> now).
> 
> ab402ac69352712dc6609fb3849a9406d1caf145 needed changes as noted in the commit
> message.
> 
> e08da21e93093c5089e70d928a3a62b9ce638b90 likewise.
> 
> 8903924c919b1019bec22b0cc7c86dcac28d9f49 needed a merge in the test.
> 
> f88d7731ea56b1ff6e9d37b461f4a6f719a0c689 needed changes as noted in the commit
> message.
> 
> 0ad4e102e01872d3f8328361d49bbd48dae193f1 is new.
> 
> 0d34a29cf18cd04155e35c6b8fee538b233eca73 needed changes as noted in the commit
> message.
> 
> All subsequent commits haven't been looked at yet; they include correcting your
> complaint from Comment #14.

I checked these commits and they looked fine to me.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.