[Bug 28200] TpBaseContactList

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28200

--- Comment #22 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-06-09 04:12:37 PDT ---
(In reply to comment #21)
> Any reason to return TP_CONTACT_METADATA_STORAGE_TYPE_ANYONE by default rather
> than NONE?

Connections that can never alter contacts' groups are expected to not implement
TP_TYPE_MUTABLE_CONTACT_GROUP_LIST, which results in GetGroupStorage = NONE
anyway.

If the default implementation of the virtual method also returned NONE, then
implementing TP_TYPE_MUTABLE_CONTACT_GROUP_LIST without also reimplementing
get_group_storage would be meaningless - it'd be the same as not implementing
TP_TYPE_MUTABLE_CONTACT_GROUP_LIST, but with more boilerplate.

By choosing a default, I reduce the amount of boilerplate slightly for
connections where that default is appropriate; I expect ANYONE to be the most
common, and it's also the least astonishing.

(There's a similar situation for CanChangeSubscriptions - if you don't
implement TP_TYPE_MUTABLE_CONTACT_LIST it's always False, but if you do
implement TP_TYPE_MUTABLE_CONTACT_LIST, the default implementation of
can_change_subscriptions always returns True.)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.