[Bug 27271] clean up TplLogEntry, TplLogEntryText API

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Jun 9 15:45:25 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=27271

--- Comment #17 from Cosimo Alfarano <cosimo.alfarano at collabora.co.uk> 2010-06-09 06:45:25 PDT ---
> > >   /**
> > >    * TplLogEntry::log-id:
> > >    *
> > >    * A token which can be trusted as unique over time within TPL.
> > 
> > Not really :-P See Bug #26838.
> 
> Changing things requier more design and thoughts. What about removing this
> guarantee for now? In practice Empathy doesn't rely on it anyway.

TplLogEntry::log-id is craeted by _tpl_create_message_token() (there is a
comment about Bug #26838 before this function declaration).

Which is a hash of channel-path, timestamp and pending-msg-id.

This should guarantee uniqueness, at least for the fact that it's not possible
(confirm? :) to have two messages having the same p-msg-id and timestamp within
the same channel.

Hashing the triplet should be fine, AFAIK.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list