[Bug 28413] Gabble DTMF

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28413

--- Comment #4 from Will Thompson <will.thompson at collabora.co.uk> 2010-06-09 10:49:10 PDT ---
Review of attachment 36104:
 --> (https://bugs.freedesktop.org/review?bug=28413&attachment=36104)

Thanks for the patch; generally looks good! Does it work with the Empathy
dialpad? A couple of small things.

For starters, git commit messages are normally formatted with a shortish (less
than 60 characters) "subject", followed by a blank line, and then the body of
the message. So maybe something like:

  Implement Channel.Interface.DTMF

  This allows the Empathy dialpad to be used when calling Asterisk with Jingle.
Fixes https://bugs.freedesktop.org/show_bug.cgi?id=28413

A smoke test would be nice. I would cargo-cult from
tests/twisted/jingle/call-state.py, tearing out the CallState-specific stuff,
and checking:

• the channel has the DTMF interface (where the test currently looks for
cs.CHANNEL_IFACE_CALL_STATE in chan_props['Interfaces'], but probably using the
assertContains() helper function from servicetest, which didn't exist when this
test was written);
• calling StartTones() and StopTones() with invalid stream IDs returns an
error;
• calling them with valid IDs causes the signals to be emitted on the
StreamHandler.

(Actually, in recent spec. versions the semantics of the DTMF interface changed
slightly to say that DTMF events should be sent on all audio streams — see
http://telepathy.freedesktop.org/spec/org.freedesktop.Telepathy.Channel.Interface.DTMF.html#org.freedesktop.Telepathy.Channel.Interface.DTMF.StartTone
— so if you were feeling keen you could change the implementation to do that.)

::: src/media-stream.c
@@ +1852,3 @@
+gabble_media_stream_start_telephony_event (GabbleMediaStream *self, guchar
event)
+{
+  DEBUG ("called");

These DEBUG messages aren't particularly helpful unless they say which stream
and event they apply to. (Yes, Gabble is riddled with such
not-enormously-helpful debug messages. ☺)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.