[Bug 28557] escaped characters in accounts.cfg are dealt with incorrectly

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Jun 15 19:49:44 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=28557

--- Comment #1 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-06-15 10:49:44 PDT ---
> static gchar *
> get_value (const McpAccountManager *ma,
>     const gchar *acct,
>     const gchar *key)
> {
>   McdPluginAccountManager *self = MCD_PLUGIN_ACCOUNT_MANAGER (ma);
>   return g_key_file_get_value (self->keyfile, acct, key, NULL);
                      ^^^^^^^^^
> }

but:

> static void
> set_value (const McpAccountManager *ma,
>     const gchar *acct,
>     const gchar *key,
>     const gchar *value)
> {
>   McdPluginAccountManager *self = MCD_PLUGIN_ACCOUNT_MANAGER (ma);
> 
>   if (value != NULL)
>     g_key_file_set_string (self->keyfile, acct, key, value);
                 ^^^^^^^^^^
>   else
>     g_key_file_remove_key (self->keyfile, acct, key, NULL);
> }

This is not how you do GKeyFile.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list