[Bug 28552] Bind Account.ConnectionError/Details

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28552

--- Comment #1 from Will Thompson <will.thompson at collabora.co.uk> 2010-06-15 11:01:55 PDT ---
Hmm.

This code:

+        if (changed) {
+            if (connectionStatus == ConnectionStatusConnected) {
+                connectionError = QString();
+                connectionErrorDetails.clear();
+            } else if (connectionError.isEmpty()) {
+                connectionError = ConnectionHelper::statusReasonToErrorName(
+                        connectionStatusReason, oldConnectionStatus);
+            }

depends on the ConnectionError always changing at the same time as the
ConnectionStatus. If it changes just before the ConnectionStatus, then the
error received will be ignored, and then the status will change and we don't
know why.

I just read the MC source and I think it'll actually do the right thing here,
so I'm not sure it's worth doing anything more elaborate. Maybe worth adding a
debug() message if connectionError becomes non-empty but the status isn't
Disconnected?

Otherwise looks good!

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.