[Bug 27792] add Vala bindings

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Jun 18 17:16:35 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=27792

--- Comment #15 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-06-18 08:16:34 PDT ---
> +  PKG_CHECK_MODULES(LIBTEST_VALA_LOWLEVEL,
> +                    [glib-2.0 >= 2.22,
> +                     gobject-2.0 >= 2.22])

I still don't see why you need this. Not only does LIBTEST_VALA_LOWLEVEL not
exist in the patches you've submitted, but you can just use GLIB_CFLAGS,
GLIB_LIBS.

You don't need to include GLib in the check for Vala either (indeed, we check
for a strictly newer version further up the configure.ac already).

It seems to be a popular pattern to say, in a project called Foo,

    PKG_CHECK_MODULES([FOO], [bar >= 1, baz >= 2])

but that's not really right - FOO isn't what you're asking for at all. I think
the ./configure message

    checking for FOO... yes

illustrates that this isn't the intended usage :-P

Another reason to check for libraries separately (as we do in telepathy-glib),
rather than having a single DEPENDENCIES variable and check, is given by the
GStreamer module policy:

<http://cgit.freedesktop.org/gstreamer/gstreamer/tree/docs/random/moving-plugins#n72>
>   - should list libs and cflags in stack order, with lowest in the stack first
>     (so one can link against highest in the stack somewhere else without
>      picking up everything from the somewhere else)
>     e.g. $(GST_PLUGINS_BASE_CFLAGS) \
>          $(GST_BASE_CFLAGS) \
>          $(GST_CFLAGS) $(CAIRO_CFLAGS)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list