[Bug 28192] support for immutable accounts in Mission Control

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28192

--- Comment #8 from Eitan Isaacson <eitan.isaacson at collabora.co.uk> 2010-06-18 10:58:06 PDT ---
The spec is a draft in master. Please canonize it!

(In reply to comment #7)
> With a few more adjustments, this looks OK to merge when the spec lands in
> telepathy-glib.
> 
> > +    if (priv->storage_plugin)
> > +      {
> > +        g_object_unref (priv->storage_plugin);
> > +        priv->storage_plugin = NULL;
> > +      }
> 
> Non-merge-blocker: if you depend on telepathy-glib 0.11.7 (which I think
> current MC master already needs), you can replace this block with:
> 
>     tp_clear_object (&priv->storage_plugin);
> 

a37accf

> > +    const gchar *account, GValue *identifier)
> 
> One arg per line in definitions, please.

8c45ea7

> 
> >  mcp_account_storage_get_identifier (const McpAccountStorage *storage,
> ...
> > +  g_return_if_fail (!G_IS_VALUE (identifier));
> 
> This will be happy with identifier == NULL, which is also an error. Add:
> 
>     g_return_if_fail (identifier != NULL);
> 

79702ef

> > + * Returns: a caller owned #GHashtable mapping of #gchar keys and #GValue
> > + * values.
> 
> "#GHashTable" (note capitalization)
> 

8c45ea7

> > +  if (iface->get_additional_info != NULL)
> > +    rv = iface->get_additional_info (storage, account);
> > +
> > +  if (iface->get_additional_info == NULL || rv == NULL)
> > +    rv = g_hash_table_new (g_str_hash, g_str_equal);
> 
> You can simplify the second "if" to "if (rv == NULL)", since you initialize rv
> at the beginning. FYI we typically call the thing to be returned "ret", but
> "rv" is fine too.
> 

0843f49

> > + *   mcp_account_storage_iface_implement_get_dentifier (iface,
> 
> "identifier"

8c45ea7

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.