[Bug 28653] Make rationale blocks collapsible.

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Jun 22 15:22:58 CEST 2010


Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
                URL|                            |http://git.collabora.co.uk/
                   |                            |?p=user/wjt/telepathy-spec-
                   |                            |wjt.git;a=shortlog;h=refs/h
                   |                            |eads/collapsable-rationale
           Keywords|                            |patch

--- Comment #1 from Will Thompson <will.thompson at collabora.co.uk> 2010-06-22 06:22:57 PDT ---
I think this is ready for review. I added little triangles.


Olivier pointed out:

 Tester | wjt: if you're gonna hide rationales in the normal 
          case.. someone should probably review them to make sure they're 
          really rationales.. as an example.. look at MessageReceived (which 
          its really a warning to implementors)
    wjt | Tester: that's a good point.
 Tester | maybe there should be a <warning> tag/box also
    wjt | i'm going through the messages interface anyway at the
          moment... and this double signal emission thing just 
          suggests that we should require Messages and move on :)
 Tester | and get rid of Text ?

So in my branch over at bug 28613 I made sure that the stuff hidden in
rationales in Messages is moved out of them.

Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

More information about the telepathy-bugs mailing list