[Bug 21735] Gabble should use ConnectionError to give better errors

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=21735

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://git.collabora.co.uk/
                   |                            |?p=user/smcv/telepathy-gabb
                   |                            |le-smcv.git;a=shortlog;h=re
                   |                            |fs/heads/errata
             Status|NEW                         |ASSIGNED
           Keywords|                            |patch
         AssignedTo|telepathy-bugs at lists.freede |simon.mcvittie at collabora.co
                   |sktop.org                   |.uk

--- Comment #2 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-06-23 06:55:26 PDT ---
Here's some infrastructural work for this, which doesn't improve on the current
error mappings much, but does at least implement ConnectionError.

The next step would be to extend the error mapping functions to cover all Wocky
errors; we can also add any missing errors to tp-spec.

(In reply to comment #0)
> </query><error code='500' type='wait'><resource-constraint
> xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'/><text
> xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'>Users are not allowed to register
> accounts so quickly</text></error></iq>

Perhaps resource-constraint should even be Service_Busy? Gabble with this
branch would map it like that if it's a WockyXmppError, or to something else if
it's a WockyConnectorError.

(In reply to comment #1)
> ConnectionError would also let us emit a better error when we get the
> <hostname-unknown/> stream error. Currently, we emit AuthenticationFailed,
> because the most likely scenario is using a non-Google Talk JID with the
> connect server set to talk.google.com.

This is still Authentication_Failed at the moment; we could add a Wrong_Server
or Hostname_Unknown error, perhaps?

Ideally, Wrong_Server would put extra keys in @details to indicate what's
wrong, something like this:

ConnectionError(Wrong_Server, { "debug-message": "host unknown",
    "connected-to": "talk.google.com",
    "requested-hostname": "collabora.co.uk" })

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.