[Bug 28742] Import Connection.Interface.StoredMessages from rtcom-tp-glib

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28742

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|telepathy-bugs at lists.freede |will.thompson at collabora.co.
                   |sktop.org                   |uk

--- Comment #2 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-06-28 03:13:10 PDT ---
The first two patches "Add a type synonym for message part IDs", "Allow arrays
of Protocol_Message_Token" are obviously OK; please merge.

My worry about the new interface is that it's defined in terms of
'message-token', but as I understand it, the unique identifiers in SMS are
actually what we'd now call a 'protocol-token' (i.e. they're temporarily unique
per contact, but not globally unique).

> Persistently-stored messages MUST also contain a stored-message-received
> header. The first time the message is announced in MessageReceived, this
> SHOULD be identical to the message-token; if the message might have been
> presented earlier, the stored-message-received  header MAY differ from the
> message-token.

This could do with rationale. What's it for? If the intention is that it's the
original value of message-token, say so; if the intention is that in
re-deliveries it's the new protocol-level ID, again, say so.

See Bug #26838 for a third sort of message identifier; if this is appropriate
for what you need, please use that one.

> If the message has been presented earlier in this Connection's lifetime,
> a header rescued with boolean value True  SHOULD be present.

Is this compatible with the usual meaning of 'rescued', which is essentially "a
logger that has been paying attention should already have seen this"?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.